[17.0][MIG] sale_timesheet_rounded: Migration to 17.0 #659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the idea of this module is to replace the regular
unit_amount
withunit_amount_rounded
by adding it as a field in theread_group
method, and then replacingunit_amount
withunit_amount_rounded
.In v17, the fields readed and the groupby are hard-coded when dealing with sales order lines, and the static loop element makes implementing the rounded flow prone to bugs. Therefore, I suggest overriding the method
_get_delivered_quantity_by_analytic
with hooks.